fix: strip leading 'v' prefix from version strings to prevent double-v display#1
Merged
simongdavies merged 1 commit intohyperlight-dev:mainfrom Mar 23, 2026
Conversation
…v display VERSION env var and __HYPERAGENT_VERSION__ build-time injection could include a 'v' prefix (e.g. from git tags like 'v0.1.0'). Since callers already prepend 'v' for display, this caused 'vv0.1.0' in the banner. - Strip leading 'v' from process.env.VERSION in build-binary.js - Strip leading 'v' from __HYPERAGENT_VERSION__ in version.ts - Reject plugin manifest versions with 'v' prefix in validator - Add test for version prefix validation Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VERSION env var and HYPERAGENT_VERSION build-time injection could include a 'v' prefix (e.g. from git tags like 'v0.1.0'). Since callers already prepend 'v' for display, this caused 'vv0.1.0' in the banner.