feat: Implement TertiaryTapCallbacks on new event system#3899
Draft
luanpotter wants to merge 1 commit intomainfrom
Draft
feat: Implement TertiaryTapCallbacks on new event system#3899luanpotter wants to merge 1 commit intomainfrom
luanpotter wants to merge 1 commit intomainfrom
Conversation
8895f2c to
e02a927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following up on our events master plan.
This adds
TertiaryTapCallbacksand necessary infrastructure to make it work.This replaces the old
TertiaryTapDetector(which we can deprecate later), e.g.:With
TertiaryTapCallbacksfollowing the newer patterns in flame:Also fixes
GestureDetectorBuilder.add()to compose initializers when multiple dispatchers share the same gesture recognizer type (e.g.SecondaryTapDispatcherandTertiaryTapDispatcherboth useTapGestureRecognizer). Previously the second dispatcher's initializer was silently ignored.Also adds example, tests, and documentation.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?