feat: Instrument CNI interface with OpenTelemetry tracing#132
Open
jipperinbham wants to merge 1 commit intocontainerd:mainfrom
Open
feat: Instrument CNI interface with OpenTelemetry tracing#132jipperinbham wants to merge 1 commit intocontainerd:mainfrom
jipperinbham wants to merge 1 commit intocontainerd:mainfrom
Conversation
jipperinbham
force-pushed
the
feat/otel-tracing
branch
from
b5e38d8 to
7e84917
Compare
Creates a span for each interface function where context.Context is available and additional creates child spans for the critical attach functions for each network being created. Goes along with containernetworking/cni#1173 to provide end-to-end traces for setting up CNI. Signed-off-by: JP Phillips <jonathanphillips@netflix.com>
jipperinbham
force-pushed
the
feat/otel-tracing
branch
from
7e84917 to
7dfe3e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a span for each interface function where
context.Contextis available and creates child spans for the critical attach functions for each network being created.Goes along with containernetworking/cni#1173 to provide end-to-end traces for setting up CNI.